You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds two features to the otomi apply command:
There are two environment variables, APPS_REPO_URL and APPS_REVISION, which allow configuring the repoURL and targetRevision of ArgoCD application manifests when using otomi apply-as-apps or otomi apply --tekton. This way, feature branches can be pushed to other locations than the public GitHub repo for experimental purposes.
otomi apply --tekton supports selectors, e.g. by file or name, for selectively configuring the ArgoCD applications.
These two come in useful when testing a new version of an app, without pushing all incremental changes to GitHub. Also, using the selectors, it does not keep re-enabling apl-operator, reverting any potential changes sent from a local Otomi CLI. Application upgrades can be tested on top of different releases, e.g. main and the previous release, without creating a separate feature branch for each combination.
Example, which only updates a single app with a new chart (provided that the Core repo was mirrored to the cluster):
These changes are for development use. Without setting any environment variables or selectors, they should not affect the behavior of the apl-operator.
I realized that using the selectors on apply with --tekton is now exactly the same behavior as apply-as-apps. I thought of reverting that part, but I did not find it intuitive that the --tekton flag ignores selectors and applies all apps, and without the flag it respects them. Either way, we should probably clean that up soon, and make a clear separation between apply and apply-as-apps.
I realized that using the selectors on apply with --tekton is now exactly the same behavior as apply-as-apps. I thought of reverting that part, but I did not find it intuitive that the --tekton flag ignores selectors and applies all apps, and without the flag it respects them. Either way, we should probably clean that up soon, and make a clear separation between apply and apply-as-apps.
It's not exactly the same right? In the apply we also update the deployment state in the configmap and make sure that some k8s resources are there.
I was more thinking of splitting up the apply command into an Install command and an Apply command. There we could have better separation of concerns and also make the commands testable.
j-zimnowoda
changed the title
ci: set custom repository and use selectors on argocd applications
feat: set custom repository and use selectors on argocd applications
Jun 27, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
j-zimnowoda
changed the title
📌 Summary
This PR adds two features to the
otomi applycommand:APPS_REPO_URLandAPPS_REVISION, which allow configuring therepoURLandtargetRevisionof ArgoCD application manifests when usingotomi apply-as-appsorotomi apply --tekton. This way, feature branches can be pushed to other locations than the public GitHub repo for experimental purposes.otomi apply --tektonsupports selectors, e.g. by file or name, for selectively configuring the ArgoCD applications.These two come in useful when testing a new version of an app, without pushing all incremental changes to GitHub. Also, using the selectors, it does not keep re-enabling
apl-operator, reverting any potential changes sent from a local Otomi CLI. Application upgrades can be tested on top of different releases, e.g.mainand the previous release, without creating a separate feature branch for each combination.Example, which only updates a single app with a new chart (provided that the Core repo was mirrored to the cluster):
🔍 Reviewer Notes
These changes are for development use. Without setting any environment variables or selectors, they should not affect the behavior of the apl-operator.
🧹 Checklist